Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace Popup bubble with Material Button #4474

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

Replace Popup bubble with Material Button #4474

wants to merge 3 commits into from

Conversation

sowjanyakch
Copy link
Contributor

Resolve #4391

🚧 TODO

  • ...

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not needed
  • 🔖 Capability is checked or not needed
  • 🔙 Backport requests are created or not needed: /backport to stable-xx.x
  • 📅 Milestone is set
  • 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

@sowjanyakch sowjanyakch changed the title Popup bubble Replace Popup bubble with Material Button Nov 21, 2024
@sowjanyakch sowjanyakch marked this pull request as ready for review November 21, 2024 18:19
@sowjanyakch sowjanyakch self-assigned this Nov 21, 2024
@sowjanyakch sowjanyakch added the 3. to review Waiting for reviews label Nov 21, 2024
mahibi
mahibi requested changes Nov 26, 2024
View reviewed changes
Copy link
Collaborator

@mahibi mahibi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the behavior of the button is now different for me. When clicked, the list will scroll as expected but the button won't disappear.

Only after a pull to refresh it seems to work that the button disappears for the next time it's clicked..

@mahibi
Copy link
Collaborator

mahibi commented Nov 26, 2024

please remove the dependency of the popup bubble

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 6, 2024

Codacy

Lint

TypemasterPR
Warnings158158
Errors7368

SpotBugs

CategoryBaseNew
Bad practice66
Correctness1616
Dodgy code7171
Internationalization33
Malicious code vulnerability33
Performance44
Security11
Total104104

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 6, 2024

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/4474-talk.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud Talk app.

@mahibi
Copy link
Collaborator

mahibi commented Dec 10, 2024

the behavior of the button is now different for me. When clicked, the list will scroll as expected but the button won't disappear.

Only after a pull to refresh it seems to work that the button disappears for the next time it's clicked..

still the same for me

@sowjanyakch sowjanyakch marked this pull request as draft December 13, 2024 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mahibi mahibi mahibi requested changes

@rapterjet2004 rapterjet2004 Awaiting requested review from rapterjet2004

Requested changes must be addressed to merge this pull request.

Assignees

@sowjanyakch sowjanyakch

Labels
3. to review Waiting for reviews
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

get rid of com.nextcloud.ui.popupbubble.PopupBubble
2 participants
@sowjanyakch @mahibi